Add support for rhel10.0 and rhel10.1 #496
Conversation
shivakunv
force-pushed
the
supportrhel10
branch
2 times, most recently
from
9a3e0d9 to
3820eed
Compare
shivakunv
force-pushed
the
supportrhel10
branch
6 times, most recently
from
38cebfe to
56f469c
Compare
shivakunv
left a comment
shivakunv
left a comment
There was a problem hiding this comment.
help needed here.
Please check which base image and driver version to use for RHEL10 support .
@rajathagasthya @tariq1890 @cdesiniotis
shivakunv
force-pushed
the
supportrhel10
branch
4 times, most recently
from
70e7101 to
6e35a8e
Compare
|
Please find addtional information regarding extrapackage and driver version availability:- used gunzip instead of |
shivakunv
force-pushed
the
supportrhel10
branch
4 times, most recently
from
5de7278 to
b460e52
Compare
shivakunv
force-pushed
the
supportrhel10
branch
from
b460e52 to
e5ecf60
Compare
shivakunv
force-pushed
the
supportrhel10
branch
2 times, most recently
from
d38fdc5 to
386913d
Compare
shivakunv
force-pushed
the
supportrhel10
branch
from
64c1151 to
be8a570
Compare
shivakunv
left a comment
shivakunv
left a comment
There was a problem hiding this comment.
I have added comments regarding some minor changes that differ from rhel9.
|
|
||
| extra_pkgs_install() { | ||
| if [ "$DRIVER_TYPE" != "vgpu" ]; then | ||
| if dnf module list nvidia-driver:${DRIVER_BRANCH}-dkms 2>/dev/null | grep -q "nvidia-driver"; then |
There was a problem hiding this comment.
I added a condition to check for the availability of dkms, as it is currently not available for 580 driver
There was a problem hiding this comment.
I prefer a check like this if [ "$DRIVER_BRANCH" -ge "580" ]; then for these conditional blocks. Can you find out which driver branches don't have this particular dnf module ?
| echo "Installing Linux kernel headers..." | ||
| # Check if kernel headers are already available (mounted from host) | ||
| if [ -d "/usr/src/kernels/${KERNEL_VERSION}" ]; then | ||
| echo "Kernel headers for ${KERNEL_VERSION} already present at /usr/src/kernels/${KERNEL_VERSION}" |
There was a problem hiding this comment.
I have added a condition for installing the kernel headers.
There was a problem hiding this comment.
Is this change strictly needed for RHEL 10? If this is a cleanup or enhancement, let's do it in a follow-up instead
| ln -s /usr/src/kernels/${KERNEL_VERSION} /lib/modules/${KERNEL_VERSION}/build | ||
|
|
||
| echo "Installing Linux kernel module files..." | ||
| if ! dnf -q -y --releasever=${DNF_RELEASEVER} install kernel-${KERNEL_VERSION} > /dev/null 2>&1; then |
There was a problem hiding this comment.
I have added a condition for installing the kernel headers.
There was a problem hiding this comment.
Is this change strictly needed for RHEL 10? If this is a cleanup or enhancement, let's do it in a follow-up instead
| echo "kernel requires gcc version: 'gcc-${gcc_version}', current gcc version is '${current_gcc}'" | ||
|
|
||
| if ! [[ "${current_gcc}" =~ "gcc-${gcc_version}"-.* ]]; then | ||
| echo "WARNING: GCC version mismatch detected, but attempting to continue..." |
There was a problem hiding this comment.
gcc mismatch handled gracefully
There was a problem hiding this comment.
Is this change strictly needed for RHEL 10? If this is a cleanup or enhancement, let's do it in a follow-up instead
shivakunv
force-pushed
the
supportrhel10
branch
from
be8a570 to
fb9ac92
Compare
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
shivakunv
force-pushed
the
supportrhel10
branch
from
fb9ac92 to
8baa52b
Compare
|
|
||
| extra_pkgs_install() { | ||
| if [ "$DRIVER_TYPE" != "vgpu" ]; then | ||
| if dnf module list nvidia-driver:${DRIVER_BRANCH}-dkms 2>/dev/null | grep -q "nvidia-driver"; then |
There was a problem hiding this comment.
I prefer a check like this if [ "$DRIVER_BRANCH" -ge "580" ]; then for these conditional blocks. Can you find out which driver branches don't have this particular dnf module ?
rhel10/install.sh
Outdated
| # Download unzboot as kernel images are compressed in the zboot format on RHEL 9 arm64 | ||
| # unzboot is only available on the EPEL RPM repo | ||
| rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-9 | ||
| dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm |
There was a problem hiding this comment.
we should be using EPEL 10, not 9. If dnf install -y unzboot does work in EPEL 10, then there is probably another command to install unzboot in RHEL 10 + EPEL 10 envs
There was a problem hiding this comment.
Using references like this will help you find out the correct package repos and installation commands
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
No description provided.